search

modularml / stack-pr

A tool for working with stacked PRs on github.
Other
301 stars 11 forks source link

Fix delete_remote_branches #27

Closed cleithner-comcast closed 1 month ago

cleithner-comcast commented 1 month ago

delete_remote_branches formatted remote branch refs with an extra single quote around each branch. These would never match the branch strings stored in stack entries, so remote branches would never get deleted. This commit removes the extra single quotes.

cleithner-comcast commented 1 month ago

I submitted two PRs fixing issues I found with the tool while using it for the first time today. Happy to modify anything according to contributing guidelines. Other than testing using the tool on my own project, I did not test it in any other way.

ZolotukhinM commented 1 month ago

Thank you for the fixes, I merged this one and left some comments on the other one!