modularml / stack-pr

A tool for working with stacked PRs on github.
Other
301 stars 11 forks source link

confusing order of stacked PRs in PR description #41

Closed GiorgosAlexakis closed 1 month ago

GiorgosAlexakis commented 1 month ago

Even though the order follows the same pattern as when looking at commits with git log, it may be confusing for reviewers to see stacked PRs in reverse order.

GiorgosAlexakis commented 1 month ago

@ZolotukhinM what do you think we should do?

I can help by writing code if needed.

ZolotukhinM commented 1 month ago

It would be confusing to some people no matter which way we choose, and adding an option can made it even more confusing if one has to review stacks from people with different order settings. So far the design principle we've sticked was to mimic what git does, so I'd say we should stick with the current way and don't change it.