modularml / stack-pr

A tool for working with stacked PRs on github.
Other
284 stars 10 forks source link

Land No Longer Deletes Remote Branch(es) #48

Open cleithner-comcast opened 1 week ago

cleithner-comcast commented 1 week ago

Version: 0.1.3

stack-pr generates remote branches in the form <user>/stack/# when you submit a stack. In 7cbd8ab it was asserted that Github deletes remote branches automatically. This only seems to be true if Automatically delete head branches setting is configured on the project. This does not seem to be a default. At present, stack-pr will leave these intermediate stack branches behind on the remote. stack-pr should query this setting if possible, and err on the side of removing resources (refs) it creates.

ZolotukhinM commented 1 week ago

Oh, interesting, thanks for the report!