search

modularscale / modularscale-js

A JavaScript modular scale calculator
http://modularscale.com
86 stars 10 forks source link

Make an NPM module #1

Closed scottkellum closed 7 years ago

scottkellum commented 9 years ago

https://github.com/yurivictor/typebetter/pull/10

scottkellum commented 9 years ago

https://www.npmjs.com/package/modularscale-js

KyleAMathews commented 9 years ago

BTW, adding a UMD header to the file would help make this module more consumable. Many JS apps now expect to be able to require frontend code using requires e.g. var ms = require('modularscale-js')

scottkellum commented 9 years ago

@KyleAMathews Thanks! I will read up and try to implement.

rafegoldberg commented 7 years ago

agree with @KyleAMathews re: adding UMD compatibility for var ms= require('modular-scale')

scottkellum commented 7 years ago

Could one of y’all PR this UMD thing? It’d help me a lot

KyleAMathews commented 7 years ago

Eh commonjs won so UMD isn't really necessary anymore. Just add a module.exports = ms at the end and you're good.

scottkellum commented 7 years ago

@KyleAMathews Thanks, apologies for my ignorance but where do I add this?

KyleAMathews commented 7 years ago

At the bottom of modularscale.js

On Sun, Apr 2, 2017, 6:06 PM Scott Kellum notifications@github.com wrote:

@KyleAMathews https://github.com/KyleAMathews Thanks, apologies for my ignorance but where do I add this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/modularscale/modularscale-js/issues/1#issuecomment-291018644, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEVh2r6Cng7D_gPuDl1E1oEiO4um7wsks5rsBv3gaJpZM4DpvzP .

scottkellum commented 7 years ago

ah, ok thanks