search

modularscale / modularscale-js

A JavaScript modular scale calculator
http://modularscale.com
86 stars 10 forks source link

Default ratio should be perfect fifth (1.5) #10

Closed nickserv closed 4 years ago

nickserv commented 4 years ago

Both modularscale.com and modularscale-sass use the perfect fifth (1.5) ratio as the default. This library defaults to the golden ratio (1.618) though, which could be confusing, especially if someone switches implementations to/from this library and expects the same default scale.

nickserv commented 4 years ago

Nevermind, the code seems to be correct: https://github.com/modularscale/modularscale-js/blob/3.0/modularscale.js#L23

I'll fix the readme instead