search

modularscale / modularscale-sass

Modular scale calculator built into your Sass
http://www.modularscale.com
MIT License
1.98k stars 132 forks source link

Pixel Rounding #132

Closed OllieBrkr closed 8 years ago

OllieBrkr commented 8 years ago

Is there a reason why we're rounding to whole pixel values (_round-px.scss)?

To be it seems contradictory to using a modular scale in the first place. From some basic checking it doesn't seem like Chrome, Firefox or Safari will round values automatically so I can't see it being a consistency issue.

Is there something I'm missing? Would love some clarification on this. Thanks!

scottkellum commented 8 years ago

Hey @OllieBrkr it helps keep output as minimal as it needs to be. For 2x screens I can see some advantages of rounding to .5 instead of whole numbers but the irregularity across all devices makes me think rounding to the nearest pixel, as the smallest consistent unit on all devices, is appropriate.

I tend to recommend using modular scale with em or rem as the relativity of those units tends to work best with how scales work

OllieBrkr commented 8 years ago

Hey @scottkellum, thanks for the fast response :)

Makes sense to me. Just makes me a little sad how specific modular-scale lets us be in terms of how fonts relate to each other, yet rounding them removes a fair amount of that accuracy.

scottkellum commented 8 years ago

Yeah I get that, it’s kinda false accuracy though as browsers do the rounding anyway.