modularscale / modularscale-sass

Modular scale calculator built into your Sass
http://www.modularscale.com
MIT License
1.98k stars 132 forks source link

Non-integer values with libsass #133

Closed gfellerph closed 7 years ago

gfellerph commented 7 years ago

Any chance of getting doubles to work in libsass?

The following line: font-size: ms(1.5, $golden);

generates the same output as this one: font-size: ms(2, $golden);

gfellerph commented 7 years ago

Never mind, got it to work by installing https://github.com/terkel/mathsass and importing it before the modularscale-sass node_module. Think this might help someone else in the same situation (modularscale-sass checks the existence of the pow(x, y) function and defaults back to integers only if it does not exist. mathsass provides this function).

For the record, I'm using the following setup:

Thanks for the awesome library!

strarsis commented 7 years ago

This may be also related: https://github.com/modularscale/modularscale-sass/issues/112