search

modularscale / modularscale-sass

Modular scale calculator built into your Sass
http://www.modularscale.com
MIT License
1.98k stars 132 forks source link

Both regular and non-conflict ms functions are returning raw output #159

Closed lmartins closed 6 years ago

lmartins commented 6 years ago

Hi,

Recently the library stopped working for me, and inspecting the generated CSS I've noticed that instead outputting a px value, the generated CSS now looks like this:

font-size: ms-round-px(4.3984rem);

This happens using both ms and ms-function.

jmrieger commented 6 years ago

Seconded this issue. We saw this pop up in our builds today.

leptest commented 6 years ago

Same issue. Seemed to break from version 3.0.6 ->3.0.7

buddye commented 6 years ago

yea looks like modularscale-sass/stylesheets/modularscale/_function.scss still calls it. I had to manually import the latest release and edit line 15 of _function.scss: @return ms-pow($ratio, $v) * $base;

scottkellum commented 6 years ago

Sorry I didn’t realize people were using that as a standalone function as I didn’t document it as a feature. I will add it back in and plan better for phasing it out.

scottkellum commented 6 years ago

Sorry about that y’all and thank you for alerting me to it! It’s fixed now in v3.0.8

leptest commented 6 years ago

Thanks for the quick reply and fix @scottkellum