modularscale / modularscale-sass

Modular scale calculator built into your Sass
http://www.modularscale.com
MIT License
1.98k stars 132 forks source link

$ms-range prints a bunch of DEBUG statements when compiling with libsass #94

Closed sondr3 closed 9 years ago

sondr3 commented 9 years ago

Hey, sorry for not following up on the last issue, kinda forgot about it. I'll look at it ASAP since I have a bunch of time off now.

However, I'm playing around with the $ms-range variable so I can use the @include ms-respond include to create some responsive type, however when I do this it makes gulp-sass output a bunch of DEBUG statements in the terminal:

src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.2 20em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.3 30em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.4 40em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.5 50em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.6 60em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.7 70em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.2 20em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.3 30em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.4 40em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.5 50em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.6 60em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.7 70em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.2 20em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.3 30em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.4 40em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.5 50em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.6 60em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.7 70em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.2 20em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.3 30em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.4 40em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.5 50em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.6 60em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.7 70em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.2 20em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.3 30em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.4 40em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.5 50em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.6 60em
src/assets/scss/vendor/modular-scale/_respond.scss:6: DEBUG: 1.7 70em

I was wondering if you knew any way you could possible silence this output? It's kinda annoying looking at a ton of lines flying by every time I make a minor change to some stylesheets, hah.

scottkellum commented 9 years ago

Thanks for the report! Yeah probably some debug thing I left in that needs to be removed. Sorry about that.

pushontom commented 9 years ago

@scottkellum

It's in https://github.com/modularscale/modularscale-sass/blob/1d504ba8c802e83946e9df0ad95afe6543efde61/stylesheets/modular-scale/_respond.scss

Line 6, if you comment that it removes the output. Thanks for the work on this though, it's really useful

Removing this line improved compile time by 2s, so definitely worth fixing

scottkellum commented 9 years ago

So, I got distracted and I’m doing a pretty major overhaul of the ms-respond mixin. Basically fully fluid steps instead of jumps from each step. See http://madebymike.com.au/writing/precise-control-responsive-typography/