module-federation / core

Module Federation is a concept that allows developers to share code and resources across multiple JavaScript applications
https://module-federation.io/
MIT License
1.44k stars 215 forks source link

fix(dts-plugin): emit dts relative to remote or manifest #2641

Closed ScriptedAlchemy closed 3 months ago

ScriptedAlchemy commented 3 months ago

Description

Emit dts assets relative to the remote entry or manifest filepath

currently DTS emits only to root of /dist directory. In cases where there is proxy or only static assets are uploded - the location of the DTS is outside the expected directory structure.

Ensuring that the DTS zip file is emitted relative to the location of the manifest or remote will allow user to upload just that folder and it contain all resources needed without needing to include the entire ./dist directory on the CDN

Related Issue

https://github.com/module-federation/core/issues/2550

Types of changes

Checklist

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 4b6643236161a527ab0400a84980a0830aad345e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages | Name | Type | | ---------------------------------------------- | ----- | | @module-federation/dts-plugin | Patch | | @module-federation/enhanced | Patch | | @module-federation/manifest | Patch | | @module-federation/rspack | Patch | | @module-federation/nextjs-mf | Patch | | @module-federation/node | Patch | | 3008-runtime-remote | Patch | | host | Patch | | host-v5 | Patch | | host-vue3 | Patch | | remote1 | Patch | | remote2 | Patch | | remote3 | Patch | | @module-federation/modernjs | Patch | | @module-federation/runtime | Patch | | @module-federation/webpack-bundler-runtime | Patch | | @module-federation/sdk | Patch | | @module-federation/runtime-tools | Patch | | @module-federation/managers | Patch | | @module-federation/third-party-dts-extractor | Patch | | @module-federation/devtools | Patch | | @module-federation/bridge-react | Patch | | @module-federation/bridge-vue3 | Patch | | @module-federation/bridge-shared | Patch | | @module-federation/bridge-react-webpack-plugin | Patch | | @module-federation/utilities | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for module-federation-docs ready!

Name Link
Latest commit 4b6643236161a527ab0400a84980a0830aad345e
Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/667b3086fdbb930008c597f8
Deploy Preview https://deploy-preview-2641--module-federation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.