search

module-federation / core

Module Federation is a concept that allows developers to share code and resources across multiple JavaScript applications
https://module-federation.io/
MIT License
1.55k stars 242 forks source link

storybook-addon should support Storybook v8 #3217

Open nate-summercook opened 1 week ago

nate-summercook commented 1 week ago

Clear and concise description of the problem

The module federation addon for storybook currently only supports v7 of storybook. Please upgrade this very needed plugin for usage with v8 ❤️

Suggested solution

Follow the storybook addon migration guide here https://storybook.js.org/docs/8.5/addons/addon-migration-guide

Alternative

No response

Additional context

Our project is currently locked in with storybook v7 because we rely on module federation, facing some other issues with that version. It would be nice to have a storybook-addon for module federation that supports the latest storybook version (v8 has been out for months)

Validations

ScriptedAlchemy commented 1 week ago

Do you have a repo that shows the error or problem with v8?

nate-summercook commented 1 week ago

Not right now, no. It seems to work with v8, but there's a warning that it is not compatible:

WARN The following packages are incompatible with Storybook 8.4.2 as they depend on different major versions of Storybook packages:
WARN - @module-federation/storybook-addon@3.0.5
ScriptedAlchemy commented 1 week ago

Gotcha. Then it's probably fine. Maybe we just need to widen the peer dependency list