Improve client-side version handler

module-federation / federation-dashboard

Dashboard service to command, control, and visualize module federation based systems

federation-dashboard-alpha.vercel.app

Apache License 2.0

16 stars 5 forks source link

Improve client-side version handler #207

Open ScriptedAlchemy opened 3 years ago

ScriptedAlchemy commented 3 years ago

dashboard-plugin/client-version is functional, but needs to be improved.

Functions need to be more resilient - code needs to be DRYed out further

We should consider Template from webpack to assist in writing function templates.

Look in webpack code and search for Template.asString to Template.baseFunction, a lot of templating tools are available to make it easier to format and wring blocks of strings.

What happens if a remote fails, we would need to think about what pattern could be implemented - like trying to load another version, when that promise rejects

We want to be able to track the scripts in the best way possible when injecting them.

hamatoyogi commented 3 years ago

@ScriptedAlchemy ran through the video and added a new version to dsl (0.3.1):

did see the new remoteEntry file in `dist
tried to change the Default version on the DSL application screen (which showed 0.3.1) to 0.3.0 and got this error:
not sure this should work yet 🤷🏽‍♂️

also, went to home application screen:

changed dsl to version 3.0.0
got this in the console:
which i'd expect to have shown that I'm on remote version 0.3.0.
I'm not sure this is working as expected: (on the left you see I've chosen 0.3.1 and on the right I'm getting logged that 0.3.0 is loaded)

hamatoyogi commented 3 years ago

I've pulled and merged the latest release branch, and I branched out of there. Haven't made any changes yet. Would be good to know if I did something wrong, or missing something.