module-federation / module-federation-examples

Implementation examples of module federation , by the creators of module federation
https://module-federation.io/
MIT License
5.63k stars 1.75k forks source link

[feature request] Improve DX #227

Closed Jordan-Gilliam closed 4 years ago

Jordan-Gilliam commented 4 years ago

Developer Experience is Sub-Optimal

1 I'm frustrated when dealing with the example naming convention

2 I'm frustrated when having to deal with proprietary code

3 I'm frustrated when creating an issue or feature request

Describe the solution you'd like

1 I'm frustrated when dealing with the example naming convention

If the example relies on an external library

If the example is related to a module-federation pattern

If the example is related to a rendering/hydration pattern

  • ex. [ssr-with-express-react]
  • ex. [ssg-with-hapi-react]

2 I'm frustrated when having to deal with proprietary code

proprietary code should be moved to a separate module-federation repo

  • This would reduce maintenance complexity in the examples repo + improve DX
  • The readme could mention proprietary services similar to how mf book is mentioned

3 I'm frustrated when creating an issue or feature request

Create issue templates

  • Necessary to reduce complexity as this repo continues to scale
Jordan-Gilliam commented 4 years ago

@ScriptedAlchemy I don't mind implementing the changes for problem 1 and 3 and can create separate issues. Wanted to gather thoughts first 😃

ScriptedAlchemy commented 4 years ago

Will GLADLY accept a PR