search

module-federation / module-federation-examples

Implementation examples of module federation , by the creators of module federation
https://module-federation.io/
MIT License
5.56k stars 1.73k forks source link

vite-react-microfrontends demo missing file #3645

Closed tomas-light closed 6 months ago

tomas-light commented 7 months ago

There is no such file as vite-importmap-shim.ts that is described in tscconfig.node.json include statement. I assume there is something important, please add it to git, if it so.

image

ScriptedAlchemy commented 7 months ago

Im not sure, does the example work? If so i guess not

phuynh-cm commented 6 months ago

@ScriptedAlchemy No, the example does not seem to render properly. Although there don't seem to be any errors in the console, the remote and host pages are rendering a blank screen. This may or may not be due to the missing file mentioned in this issue.

ScriptedAlchemy commented 6 months ago

Yeah the example probs needs to be rewritten.

Sadly i dont know vite and not sure whats wrong here or how to fix.

Might be worth trying to send a PR and re-implement with originjs or something

hans-ts commented 6 months ago

Unfortunately originjs does not do live-reloading or HMR, and going back to manually refreshing on changes is asking a bit too much.

ScriptedAlchemy commented 6 months ago

All implementations of MFP don't support hmr. We will soon support hmr in rspack and webpack but vite isn't going to get any of that.