modulor-js / modulor-storybook

3 stars 2 forks source link

Can we adopt Malvid? #53

Open pankajpatel opened 6 years ago

pankajpatel commented 6 years ago

https://malvid.io/ Repo: https://github.com/Malvid/Malvid Demo: https://malvid.io/ui/#/806a662853767cf69a120de2ef3618cb644edbc0/view

nogizhopaboroda commented 6 years ago

Not sure if i got the question. What do you mean by adopting it?

pankajpatel commented 6 years ago

adopting it means, maybe we can have our stories inside this tool itself

or if not, go by this design.

nogizhopaboroda commented 6 years ago

ok, but what benefits will it bring?

design - why not, looks lovely

nogizhopaboroda commented 6 years ago

i still don't get a question. if you want to render stories in that tool, then it's not related to this repo. could you please explain the proposal a bit more detailed? like how it's gonna work. just to give a clue

pankajpatel commented 6 years ago

I would like to try both ways.

  1. Render our stories in this Tool if possible
  2. If not possible, let's adopt the design

I created the issue here because the Stories are still constructs of this repo. I haven't explored the tool more thoroughly, just put it here to give it a try in later time. Or if anyone come's across, they can also do so to give a quick feedback on the possibilities.

nogizhopaboroda commented 6 years ago

about design - it seems like a good way to do it would be to provide themes so that user can decide on their own which design to choose. it can be matter of storybook config file. something like:

// .storybook/additional.js

import 'modulor-storybook/themes/dark.css'

or

// .storybook/additional.js

import 'modulor-storybook/themes/pink'
//modulor-storybook/themes/pink/index.js

import './theme.css'

this would keep current styles simple (e.g. i personally like current minimalistic design, but others might like fancy ones)