modxbot / migrate

A testground for migrating issues and other such fun
0 stars 0 forks source link

Wayfinder menu's with &startId other then 0 fail after update to Modx 2.2.9 #10157

Closed modxbot closed 11 years ago

modxbot commented 11 years ago

ThaClown created Redmine issue ID 10157

After updating my client's MODX cloud from 2.2.8 to 2.2.9 the Wayfinder menu's that use any other startId then 0 will fail:

@[[Wayfinder? &startId=[[!UltimateParent]] &level=2 &selfClass=active_here &hideSubMenus=0 &displayStart=1 &startItemTpl=navStartItemTpl &rowTpl=navRowTpl ]]@

FAILS, Gives only the StartItem using the StartItem template

@[[Wayfinder? &startId=16 &level=1 &displayStart=1 &hideSubMenus=0 &startItemTpl=navStartItemFooterTpl &rowTpl=navRowTpl]]@

FAILS, Gives only the StartItem using the StartItem template

@[[Wayfinder? &startId=0 &level=2 &rowTpl=navRowTpl &parentRowTpl=navParentRowTpl &outerClass=navigation_toggle_contgainer]]@

WORKS, so I think the error is definately with the startId.

modxbot commented 11 years ago

ThaClown submitted:

I can confirm this issue with several sites in MODX Cloud and on localhost.

modxbot commented 11 years ago

spackko submitted:

quite similar here:

[[Wayfinder?
 &startId=`0`
 &config=`myparams`
 &level=`0`
]]

myparams holds only the tpls. Everything is rendered as expected - BUT only the first level

MarkH commented 11 years ago

markh submitted:

Does it work when calling Wayfinder uncached?

(NEVER EVER call Wayfinder uncached. But it may be related to cached/uncached behaviour that changed in 2.2.9)

modxbot commented 11 years ago

ThaClown submitted:

Calling wayfinder uncached does not change it... same issue.

modxbot commented 11 years ago

sladdals submitted:

The same problem with cache if using nested snippet call in rowTpl of wayfinder: [[http://forums.modx.com/thread/86431/nested-snippet-call-in-rowtpl-wayfinder-work-inproperly-after-update-to-modx-2-2-9#dis-post-476440]]

garryn commented 11 years ago

garryn submitted:

Not finding an issue here on a clean install of 2.2.9 on localhost with latest wayfinder. My call is working as intended:

[[Wayfinder?
    &startId=`2`
    &displayStart=`1`
    &level=`2`
    &startItemTpl=`navStartItemTpl`
]]

Can you please post information on what is contained in your Wayfinder templates.

tomahl commented 11 years ago

tomahl submitted:

When I try the call without any custom templates it works. As soon as I active any custom templates it fails. In my call I have &rowTpl, &parentRowTpl and &innerTpl.

modxbot commented 11 years ago

sladdals submitted:

garryn wrote:

Not finding an issue here on a clean install of 2.2.9 on localhost with latest wayfinder. My call is working as intended:

[...]

Can you please post information on what is contained in your Wayfinder templates.

Hi Garryn, please check the first post here for details [[http://forums.modx.com/thread/86431/nested-snippet-call-in-rowtpl-wayfinder-work-inproperly-after-update-to-modx-2-2-9#dis-post-476440]]

there are some problems with caching nested snippet calls

modxbot commented 11 years ago

spackko submitted:

tracked that a little bit down:

If you put your Wayfinder call directly in your template AND fill the variables like

&innerTpl = `@CODE:`

then it works. Any other outsourcing (TPL chunks, Wayfinder call in a Chunk, Wayfinder with config) fails.

modxbot commented 11 years ago

everettg_99 submitted:

I'm seeing this behavior too: using static chunks for outerTpl and innerTpl fails in Revo 2.2.9, but it works in 2.2.8. What's really baffling to me is that if I log exactly what content Wayfinder is pulling in (by temporarily hacking its class file), I can see that is is correctly grabbing the Chunks. But if the chunks are static, only the first level of pages is printed.

See http://forums.modx.com/thread/86516/wayfinder-fails-when-using-static-chunks#dis-post-476988

opengeek commented 11 years ago

opengeek submitted:

Is this only being encountered when using Chunks that are using Static files? If so, is it only with Media Sources? Or is this a problem when using any Chunk?

exside commented 11 years ago

exside submitted:

This is related to: http://tracker.modx.com/issues/10211 and here is a temporary solution + details how to reproduce, ie reverting the change...https://github.com/roryg/ElementHelper/pull/16

opengeek commented 11 years ago

opengeek submitted:

See patch at https://github.com/modxcms/revolution/commit/5cd13cba13e52e888cff5a5209b4d88bb976daf5