modxbot / migrate

A testground for migrating issues and other such fun
0 stars 0 forks source link

Upgrade Font Awesome to v4.0.1+ #10304

Open pixelchutes opened 10 years ago

pixelchutes commented 10 years ago

pixelchutes created Redmine issue ID 10304

Loving the addition of Font Awesome to MODX v2.3.0 Manager. It gives the UI a very nice touch, especially on retina devices.

Unless there is any compelling reason to maintain IE7 vector icon support for MODX Manager in v2.3.0+, I would recommend considering the upgrade to Font Awesome 4.x sooner than later. With the 4.x release comes a lot of breaking behaviors from v3.2.x (namely a new naming convention and dropped IE7 support).

In order to prevent being "locked down" to the legacy 3.x series (think ExtJS), and also be able to take advantage of new icons as they're made available, making this jump while we're in RC/beta makes the most sense to me. Does the MODX v2.3.0 Manager officially support IE7, has that line been drawn yet?

I would be happy to assist with the request and provide a PR. I am not fully up to speed on MODX's new Sass/SCSS Grunt build process, but anxious to learn. I am familiar with Grunt builds, etc, just haven't dove too deeply into MODX 2.3.0 yet.

Are there any Sass / Font Awesome exceptions or MODX-specific customizations that one would need to be aware of before attempting this task? Any reason we would not consider using Font Awesome's 4.x branch moving forward?

pixelchutes commented 10 years ago

pixelchutes submitted:

What's New in Font Awesome 4.0: http://fortawesome.github.io/Font-Awesome/whats-new/