search

modxbot / migrate

A testground for migrating issues and other such fun
0 stars 0 forks source link

Placeholders in non-cached snippets #5222

Closed mschlegel closed 13 years ago

mschlegel commented 13 years ago

mschlegel created Redmine issue ID 5222

After upgrading to 2.1.2-pl I noticed that placeholders in snippet parameters didn't work any more, if the snippet was called uncached (e.g. Formit). The same applies for system settings placed there.

For testing I did the following:

created 'testSnippet' with this content: @return $param;@

and 'testChunk': @[[!testSnippet?param=[[+chunkParam]]]]@

When calling

@ [[$testChunk?chunkParam=some text]]@

there is no output!

Downgrading to 2.1.1-pl brought the output back. I think that this commit: https://github.com/modxcms/revolution/commit/c5ab85902d6e6102c0b1ef7e09991baceeab8088 is responsible, since reverting it brought me back the output too.

mschlegel commented 13 years ago

mschlegel submitted:

Just a note: of course the affected version is 2.1.2-pl, not 2.1.1-pl (forgot to change it)

Another note: This may be the same bug as #5201

modxbot commented 13 years ago

pavukmax submitted:

I agree with Markus. I think this is critical bug! I found workaround: if use placeholder before called snipper, it works:


[[!testSnippet?param=`[[+chunkParam]]`]]
opengeek commented 13 years ago

opengeek submitted:

This has been fixed for a 2.1.3-pl bug fix release and has been merged into develop for 2.2.0-rc1. See commit details at https://github.com/modxcms/revolution/commit/32fdbe0ce81efa67ebeb6cafe3d64f6b51d804f1