modxcms / Revise

Revise is a simple versioning component for MODX Revolution

18 stars 8 forks source link

integrate into Resource update controllers #2

Open opengeek opened 11 years ago

opengeek commented 11 years ago

Provide draft and history access from Resource update controllers, along with appropriate permissions.

Add a Save Draft control (with optional change message input)
Add a Drafts tab listing the Drafts currently saved/accessible by the current user
Add a History tab listing the History for the Resource

StevenMorgan commented 11 years ago

A couple of quick discussion points:

What is the purpose of the drafts tab? Is there a a different between drafts and resource history? Are we essentially thinking about a list of each resource "save", with some at a published status and others not, i.e. a draft?
Where you mention a Save Draft control, are we thinking if this as a different user action within the UI? I would suggest that this functionality should replace the existing Save function, the add a new action to Publish / Set Live.

There's a slight overlap in terminology between how MODX currently defines "Published", which is closer to saying enabled or disabled and the Publishing of a revision. What's the thought process on resolving this one?

StevenMorgan commented 11 years ago

Also, is this the right place to discuss how Revise could / should impact the Preview button?

Steve

opengeek commented 11 years ago

Yes, this includes any changes needed to enable Revise in the existing Resource Create and/or Update controllers.

Drafts and History are stored separately and with slightly different rules. I chose this approach because History and Drafts could have completely different behavior, lifetimes, etc.

StevenMorgan commented 11 years ago

Sounds good.

Do you envisage a situation where there could be multiple drafts? This sounds great but I just wonder if there is any benefit in simplifying to start with?

Looking forward to test driving this - I think it'll be met with a good reception from the community.

opengeek commented 11 years ago

Since drafts can be saved with a message, there can be "named" Drafts, but there is a mode already to address this . The revise/resource/draft/create processor accepts a singleDraft argument that defaults to true at the moment.

opengeek commented 11 years ago

7 added Save Draft and Preview Draft controls to the Resource Create and Update controllers. Only supports singleDraft mode at the moment.