search

modxcms / a11y

MODX Accessibility for the Manager
13 stars 10 forks source link

modx-resource-header Title needs to be H1 not H2 #54

Closed dubrod closed 8 years ago

dubrod commented 8 years ago

Per the interface requirements image.

<h2>MODX Revolution</h2> and <h2>New Document</h2> under the div modx-resource-header need to be <h1>

dubrod commented 8 years ago

the Dashboard Title is in manager/assets/modext/widgets/modx.panel.welcome.js

Line 20 = html: '<h1>'+dashboardName+'</h1>'

This would be a core change, and would require the addition of h1 to index.scss on line 130.

BUT it is active on the cloud site right now.

dubrod commented 8 years ago

@theboxer i could not find the file to change the resource title markup though

theboxer commented 8 years ago

It's in /manager/assets/modext/widgets/resource/modx.panel.resource.js line 362

,getPageHeader: function(config) {
        config = config || {record:{}};
        return {
            html: '<h2>'+_('document_new')+'</h2>'
            ,id: 'modx-resource-header'
            ,cls: 'modx-page-header'
            ,border: false
            ,forceLayout: true
            ,anchor: '100%'
        };
    }
theboxer commented 8 years ago

Resource title updated. Dashboard title needs to be changed in core