search

modxcms / a11y

MODX Accessibility for the Manager
14 stars 10 forks source link

Uberbar becomes <nav> #56

Closed dubrod closed 8 years ago

dubrod commented 8 years ago

ul#modx-topnav and ul#modx-user-menu need to be wrapped by

<ul> also gets role="menu"

<nav><h2 class="sr-only">Global Navigation</h2> 
 <ul>....
</nav>
dubrod commented 8 years ago

@kensgists @paulbohman hidden H2 is there and its wrapped. please test

dubrod commented 8 years ago

@theboxer can you look at getting the <ul> under the uberbar to add role="menu"

theboxer commented 8 years ago

Should be there

dubrod commented 8 years ago

Ok slight change in order. I believe the # modx-topnav needs role="menubar" b/c its rendered horizontally and it will be [tab] key to move along. Where as the first UL will be key arrows to move along.

so:

<ul id="modx-topnav" role="menubar">
    <li id="limenu-site" class="top" role="menuitem" aria-haspopup="true">
        <a href="javascript:;">Content</a>
        <ul class="modx-subnav" role="menu">
            <li id="new_resource" role="menuitem">

we also have to add aria-haspop="true" when an li has a submenu

theboxer commented 8 years ago

@dubrod should be ready for review

dubrod commented 8 years ago

Awesome work. looks good to me. Labeling as Needs Testing for the stakeholders.