search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

[2.3] Extras Compatibility #11630

Closed exside closed 9 years ago

exside commented 10 years ago

I think it would be good to collect working and more important not-yet-working extras in one place (maybe for the release note?) as more and more are reported.

As far as I can tell, most not-working extras are affected by the connector nuking that happened in 2.3, so they don't find the appropriate processors anymore and thus do not work anymore. Another quite commonly observed issue is the use of the depreciated $modx->getMicrotime() method in extras. Just replacing it with PHP's native function microtime(true) fixes this problem.

I suggest commenting (including version info) about successfully and not successfully tested extras in this issue and a I will update the following list.

Extras working and compatible with 2.3

Extras working in 2.3 but not showing up in package manager

Extras partially working in 2.3

Extras not working with 2.3

Extras that need testing / confirmation (list incomplete)

rthrash commented 10 years ago

For all those following this thread, would it be OK to start removing comments to make it easier to manage the updates to the list in the original ticket? Any major objections to making sure we've checked the list and caught all the updates?

rthrash commented 10 years ago

@gadgetto do we need to add GoodNews to the list?

Mark-H commented 10 years ago

The first post is already kept up to date, the comments add context as to what and when. So yes I object against removing comments.

gadgetto commented 10 years ago

@rthrash GoodNews is fully working under 2.3 :-)

exside commented 10 years ago

cannot find GoodNews in any package browser (not 2.2.x nor 2.3)

rthrash commented 10 years ago

Or at modx.com/extras/

Mark-H commented 10 years ago

GoodNews is available commercially from www.bitego.com/extras/goodnews/ ;)

amdbuilder commented 10 years ago

Copyright works and MetaX should be updated later tonight :)

hephaestoskin commented 10 years ago

Any word on CustomUrls and GoogleSiteMap ?

elz64 commented 10 years ago

Babel please!? Any news about it.? It's a manadatory extra.

DESIGNfromWITHIN commented 10 years ago

@sottwell That looks cool! Does it also support TV's and MIGX translations?

ghost commented 10 years ago

Sorry, on further examination it appears to have a problem. I'll get it fixed.

amdbuilder commented 10 years ago

I would suggest using pdoSitemap (part of pdoTools) instead of GoogleSiteMap. It's more efficient as your page count increases.

I've done some more extensive testing of some extras we use, the results:

theboxer commented 10 years ago

Collections 2.0.0 released and working with 2.3

whitebyte commented 10 years ago

AjaxManager 1.1.7-pl seems to work partially. Almost everything works good, but sometimes it throws an error "Could not find action file at: /path/to/controllers/filename.php". It also generates wrong URLs in manager, for example "http://sitename.com/manager/?a=http://sitename.com/manager/?a=workspaces" (double part of URL). The page is accessible with additional F5 though. Will send bugreport to danyaPostfactum.

gadgetto commented 10 years ago

@Mark-H Thanks Mark for mentioning! :+1:

@rthrash is it possible to have an add-on in modx.com/extras/ without having it in package provider?

ghost commented 10 years ago

If the submitter specified a version of MODX, like 2.2x, then it won't show in Package Manger for 2.3

whitebyte commented 10 years ago

AdvSearch throws an error "PHP Fatal error: Call to undefined method modX::getMicroTime() in /***/public_html/core/components/advsearch/model/advsearch/advsearchutil.class.php on line 173, referer: http://sitename.com/manager/?a=element/chunk/update&id=2"

Mark-H commented 10 years ago

FastField also seems to have issues in 2.3, still trying to narrow it down.

EDIT: Nope, not FastField having issues. PhpThumb issue. Sorry.

@whitebyte modX::getMicroTime was indeed removed (it had been deprecated for some time). Perhaps we can bring it back as it seems it's still getting used; probably worth a new issue.

ghost commented 10 years ago

That's odd, I've been using its variant in pdoTools for a while now, and haven't noticed anything unusual.

Mark-H commented 10 years ago

Sorry, it wasn't fastfield. Jumped to conclusions too soon. :D

exside commented 10 years ago

thanks @all, list updated!

davidpede commented 10 years ago

The following are all 2.3 compatible: 'getVimeo', 'getYoutube', 'cookieJar' and 'getDate'.

jpdevries commented 10 years ago

An additional patch release will be needed, but Articles should now pass all tests for 2.3 compatibility (1.7.7 does not) https://github.com/modxcms/Articles/pull/94

sebastian-marinescu commented 10 years ago

Just FYI: The "harmless error(s)" with ACE-Editor seems to mutate to "aggressive" Manager-UI-Destruction when combined with advanced FC-Rules. Thanks to @pixelchutes for the fix. Would be appreciated to add this info at the top @exside :+1:

hephaestoskin commented 10 years ago

On upgrade I get the following utilizing the pThumb, anyone have this issue?

Fatal error: Cannot redeclare phpthumb::__destruct() in /home/ties/public_html/core/model/phpthumb/phpthumb.class.php on line 254

pyrographics commented 10 years ago

Yes, it is documented elsewhere on github as duplicated classes in core/model/phpthumb/phpthumb.class.php, you can fix by removing the duplicates around line 254

11700

glenwith1n commented 10 years ago

I had an issue with Gallery, no images showing in front end and backend? Can't seem to fix it.

benjaminglick commented 10 years ago

I was able to get the Gallery to work by applying the phpthumb fix (two comments above, or here (https://github.com/modxcms/revolution/issues/11700), and then add "return;" to the end of the connector file at /assets/components/gallery/connector.php. The front end worked perfectly after that. In the manager, something was still off with the media display.

domifromch commented 10 years ago

Is there any progress with Babel? Or is there a valuable alternative for translating resources that works with 2.3?

charlie17 commented 10 years ago

In codemirror I am seeing a nasty issue where the cursor appears on the wrong line - i.e. it doesn't appear on the line you are actually editing. It only seems to happen deep into a file, say line 50+. Makes it pretty much unusable. Don't recall seeing this behavior happen in versions prior to 2.3. Any tips?

eladnova commented 10 years ago

@domifromch You're not the first person I've heard asking about Babel. Has dev of Babel been stopped by the original authors? Sounds like it needs to be adopted by someone(s) in the community.

DESIGNfromWITHIN commented 10 years ago

I have been thinking about teaming up with other modx ers to adopt Babel, not sure if I have the dev skills for it...

rthrash commented 10 years ago

Check out Lingua … it's getting some serious love and attention right now for multi-language sites.

domifromch commented 10 years ago

@rthrash Thanks for the tip. Lingua looks indeed very promising... Will give it a try!

ghost commented 10 years ago

MIGxMultiLang! But then I do love anything to do with MIGx.

pyrographics commented 10 years ago

I think the revoSSL package may have some issues with it. I was locked out the manager completely until I disabled it and manually removed the site cache.

le-genda commented 10 years ago

pThumb 2.3.3-pl doesn't work like this <img [[*imagetv:pthumb=w=200&dims=1]] alt="image"> phpThumbOf 1.4.0-pl and phpThumbsOn 1.2.1-pl, doesn't work also with TV

pThumb 2.3.3-pl work only like snippet

elz64 commented 10 years ago

Should be done.
No way to redesign sites from scratch with totally other approach (tvmultilang or lingua) because babel won't work any more. 2.3 is a pb if majors extra can be smoothly reused!! When a site is on production this is crazy to have to say " well there's no way to update, its a compatibility issue so we have to rework entirely the site". This is not serious. Multilingual solutions has always been the weak point with Modx until Babel came, and now, I can't be said oh no pb just use something else! .. And in 2 years redesign everything again ! We are talking about production sites not labs! And even if US modxers seams not to care that much about multilingual we are much more everywhere who need something stable. Thank you

(depuis iPhone)

Le 18 juil. 2014 à 17:52, Menno Pietersen notifications@github.com a écrit :

I have been thinking about teaming up with other modx ers to adopt Babel, not sure if I have the dev skills for it...

— Reply to this email directly or view it on GitHub.

exside commented 10 years ago

thanks everybody, updated the list with information till here. @Babel, what is not working correctly can't seem to find information about it, also no issues in the repo??

le-genda commented 10 years ago

I'm sorry, pThumb works. phpThumb and phpThumbsUp most likely work fine as well. This is wrong I tested it. You only need to replace phpthumb.class.php as it is written here https://github.com/modxcms/revolution/issues/11700

DESIGNfromWITHIN commented 10 years ago

I will start to test Babel with 2.3 starting tomorrow. This Plugin is critical for me and my clients.

Will post any issues. Op 19 jul. 2014 10:45 schreef "elz64" notifications@github.com:

Should be done. No way to redesign sites from scratch with totally other approach (tvmultilang or lingua) because babel won't work any more. 2.3 is a pb if majors extra can be smoothly reused!! When a site is on production this is crazy to have to say " well there's no way to update, its a compatibility issue so we have to rework entirely the site". This is not serious. Multilingual solutions has always been the weak point with Modx until Babel came, and now, I can't be said oh no pb just use something else! .. And in 2 years redesign everything again ! We are talking about production sites not labs! And even if US modxers seams not to care that much about multilingual we are much more everywhere who need something stable. Thank you

(depuis iPhone)

Le 18 juil. 2014 à 17:52, Menno Pietersen notifications@github.com a écrit :

I have been thinking about teaming up with other modx ers to adopt Babel, not sure if I have the dev skills for it...

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/modxcms/revolution/issues/11630#issuecomment-49503549 .

craigphiz commented 10 years ago

Same here @whitebyte (modX::getMicroTime error with AdvSearch) Agree with @Mark-H: bring back getMicroTime! Thank you all contributing to the great Revo 2.3 :-)

OptimusCrime commented 10 years ago

I dont understand why Modx implemented a method that simply returns a native PHP function. It makes no sense to bloat the core with such functionality.

getMicroTime should not be in the core imo.

Mark-H commented 10 years ago

getMicroTime came from the times where there was no microtime(true). Despite the method having been deprecated for some time, apparently addons still use it.

OptimusCrime commented 10 years ago

Oh, okey. But still. It would be better is addons just migrated away from it.

exside commented 10 years ago

sure, but can we expect this, e.g. is it worth breaking extras using this to just have one small method less in the core?

OptimusCrime commented 10 years ago

I think you guys are making a great work with getting extras to work with 2.3, but I still feel like this is something core developers should not have to spend time doing.

If something is deprecated, the developers of the Extras should have to take care of that, or else the Extra will no longer work. That is how it usually is.

elz64 commented 10 years ago
"If something is deprecated, the developers of the Extras should have to take care of that, or else the Extra will no longer work."

Sorry but this is once again a geeky minded way of thinking. What makes Cmf successful and what made Modx finally successful is actually not only its core or it's nice architecture. No. But the whole stuff it offers to anyone who need to USE it out from the box. Do you really think each time you need a website you should have to "reinvent warm water" ? Surely not! What makes a product usefull is the way it gives solutions to reply the simplest way to any kind of needs. For 90% of the projects we all need stable ready out of the box reliables components. There's no place for buggy stuff, so RTE, powerful and flexible gallery manager and multilingual solution are critical and mandatory in most case. A need = a couple of components mastered, always the same to be fast and efficient in the competition. So, when the core is supposed to evolve, for whatever reasons some might find mandatory, the minimum is to ensure the very popular extras - and Tiny rte or Babel are part of those- will perfectly work when the new release is launched. It's a communit,y so may be the dev of one extra will choose not to support its creation anymore. Ok. A pain, but ok, in this case this the interest of the core team, for the good of everyone, to take care of this if nobody else is able to.

Robert-rx2-Ross commented 10 years ago

ContextRouter works, but I had to add return; to the end of the plugin code to stop the error log from filling up.