search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.35k stars 527 forks source link

[2.3] Installer download display is green not blue #11656

Closed mindeffects closed 10 years ago

mindeffects commented 10 years ago

The Installer download display is green not blue: bildschirmfoto 2014-07-08 um 15 53 33

exside commented 10 years ago

yap...aware of that, also the "save" window with the progressbar uses an ugly gif =)...should be something consistent anyways I think...

mindeffects commented 10 years ago

This one is in #d0d0d0 like the header bg-color: wait Wanted to do it in GitHub but didn't manage to exchange an image file. Feel super stupid right now and will go down into the cellar and cry a little. ;-)

I would prefer an "inverted AnimGif", which reveals a partial look-through on an bg-image – just like poking holes into the gif. Then the color/img of the background could be anything and the animation would not have to change. This would need "sharp edges" to work, since index-transparency sucks allmost any time. ;-)

mindeffects commented 10 years ago

Or we drop this last century technique and use a modern one: A simple "CSS FontAwesome Spinner" with every comfort one needs. ;-) http://fortawesome.github.io/Font-Awesome/examples/#spinning A round thingy is also a nicer way to say "Look, dude, we don't know how long this will take either." :-D

exside commented 10 years ago

I'm more for the CSS option, but we need fallbacks for IE8-9 anyways...no CSS animation support there...but need some time, more critical things like windows and grids need some love first!

mindeffects commented 10 years ago

Sure thing! You will get my "personal hero"-badge anyway! :+1:

exside commented 10 years ago

thanks, but you should have a whole wall of personal heroes for the 2.3 release =), many others put countless hours in this release too and definitely deserve that badge too!

mindeffects commented 10 years ago

Sure thing. Everybody will get a badge! :-D

exside commented 10 years ago

will take your gray gif for now, thanks for re-coloring =)!

mindeffects commented 10 years ago

Any other design stuff I can help you with? Would be glad to assist!

exside commented 10 years ago

mmh, don't know about the ugly saving-progress bar gif, somehow make it flater maybe, until we get to replace this by something more sexy... =)

mindeffects commented 10 years ago

Sure thing.

mindeffects commented 10 years ago

.x-progress-bar { background-color: #d0d0d0; /* << this is the flat fg color / background-image: url("../images/modx-theme/progress/progress-bg.gif"); / << transparent */ border-bottom-color: transparent; border-right-color: transparent; border-top-color: transparent; }

.x-progress-inner { background-color: #fff; /* << this is the flat bg color / background-image: url("../images/modx-theme/qtip/bg.gif"); / << transparent */ } Use "SELECT ALL" to locate the transparent images: ;-) progress-bg bg

mindeffects commented 10 years ago

Maybe the "manager/templates/default/images/style/loading.gif" is still in use somewhere? loading Also in "#d0d0d0", again. ;-) And I changed the direction to "clockwise".

exside commented 10 years ago

The downloading gif was included in https://github.com/modxcms/revolution/pull/11698, the round loader I forgot and just added it to #11698 the loading window still needs adjustments, looking into that now.

mindeffects commented 10 years ago

This "spinner" is not (yet) included in the 2.3.0-pl, right?

exside commented 10 years ago

nope, they merged so fast, I couldn't react when I noticed that I forgot it =D...it's here #11699

rtripault commented 10 years ago

I guess everything's grey now, so closing this one. Feel free to comment/reopen if needed. Thanks :)