search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

[2.3] Misplaced slide-in/slide-out button of Resource tree when scrollbar is visible #11751

Closed gadgetto closed 5 years ago

gadgetto commented 10 years ago

The slide-in/slide-out button of Resource tree is misplaced when scrollbar is visible + it overlaps the scrollbar. Also the padding between tree border and button changes.

screenshot 2014-07-20 23 12 01

exside commented 10 years ago

have that too (when forcing scrollbars on a mac like you do), what about windows, does it look ok there?

gadgetto commented 10 years ago

This is how it looks on Windows 7 - IE11:

snipimage

whitebyte commented 10 years ago

Linux too (any browser)

exside commented 10 years ago

mmh, that's what we have from a guy (me) developing on mac^^...probably quite difficult to fix, as the collapse thing is not part of the tree (which does get the scrollbar) but of the layout splitter...

gadgetto commented 10 years ago

Any news to this issue? Using scrollbars makes the (otherwise nearly perfect) MODX tree ugly.

exside commented 10 years ago

not really, looked into it but couldn't see a solution...the tree basically doesn't have enough spacing to the right to allow for a scrollbar to fit in =/...any suggestions or ideas for solutions are welcome!

rtripault commented 10 years ago

https://github.com/modxcms/revolution/blob/master/_build/templates/default/sass/_tree.scss#L68

Set to -2 instead, and the button won't overlap the scroll bar (if any)

gadgetto commented 10 years ago

Its not only the button which overlaps the scrollbar, but the position of the scrollbar, which is too near to the tree border IMHO.

alroniks commented 5 years ago

It seems issue solved by just merged pr.