Open aesop1 opened 10 years ago
what browser are you using (+version)? the checkbox/radio replacements use :before pseudo elements in combination with a fontawesome icon. As far as I know all modern browsers support elements and for IE8 there is a special rule which should display the normal checkbox/radio again (by setting opacity to 1).
I use the latest Chrome (36.0.1985.125), Firefox and Safari browsers on Mac OS X. I can see the new checkboxes in the Document Tab of the manager (such as "Hide From Menus" and "Published"), but not the TV Tab. If you create a checkbox TV can you see it?
I just verified the issue on IE 11 for Windows as well.
absolutely, can see them, wouldn't have done that without testing, but obviously I missed something...look like that here:
could you exactly (step by step) tell me how you created it etc.?
Aha. I think I've figured out the issue. In previous versions of Modx I was able to do this for the TV input value: "==1"
But doing that in 2.3 gives you an invisible checkbox.
I realize that according to the docs that you're supposed to have something like: "Yes==1", but sometimes that extra label next to the checkbox is superfluous when you also have a label above.
Yet, if I have to label the darn thing, I'll do it, but it would be nice to have the blank option.
Aaah, good catch! I guess if you don't specify a label, e.g. the stuff before == then extJS will not render a label for the checkbox and as the icon is attached to the label.x-form-cb-label (which is not there then) the icon will not appear...will have a look at this! Thanks for reporting!
Thanks for bearing with me! I should have investigated my usage more thoroughly initially.
Glad you got this figured out. Can this issue be closed then?
no, this needs to be fixed =)!
Added empty check - https://github.com/modxcms/revolution/pull/14275
In 2.3.0 or 2.3.1 my previously visible checkbox TVs (the checkbox itself) are not visible (they are there, I can mouse over them and see the pointer). CSS issue.
It appears the new Manager style for checkboxes isn't being applied to the TVs after the standard HTML checkboxes are hidden via the CSS opacity (opacity: 0) attribute at line 21 of the Manager's index.css file:
.x-form-check-wrap .x-form-checkbox, .x-form-check-wrap input[type=checkbox], .x-form-check-wrap .x-form-radio, .x-fieldset-checkbox-toggle legend .x-form-checkbox, .x-fieldset-checkbox-toggle legend input[type=checkbox], .x-fieldset-checkbox-toggle legend .x-form-radio { cursor: pointer; opacity: 0; /This is hiding the standard checkboxes/ position: absolute; top: 0; left: 0; width: 18px; height: 18px; z-index: 1; }