search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

[2.3] Make resource fields + TVs read only when it cannot be saved #11929

Open ghost opened 10 years ago

ghost commented 10 years ago

Right now you can still change fields, even if you cannot save the resource. So if another user has locked the resource (or you just are not allowed to change it) and you don't notice the warning where the save button used to be, you can loose a lot of time on editing the page. The resource should instead be read only to make sure it's very clear that it cannot be changed.

bertoost commented 10 years ago

Yeah!! :+1:

Mark-H commented 10 years ago

Given the variety of input types (textfield, textarea, rich text, combo boxes, date fields - and then there's TVs) this would be very tricky to pull off. There are some disabled fields in ExtJS (e.g. statictextfield) but not nearly enough to really make a resource read only.

Maybe there's another way we can make it more obvious a resource is locked?

bertoost commented 10 years ago

As far I know it's possible to set all fields disabled. This would give an extra .x-item-disabled class I am right. So it should not be that hard I gues?

Mark-H commented 10 years ago

Oh, I completely forgot about that. :D

bertoost commented 10 years ago

I forgive you Mark ;-) haha

wuuti commented 10 years ago

+1

rtripault commented 10 years ago

:+1: on the idea.

Just seeing some kind of potential issue when a TV is not an input field (ie. a grid).

I guess some kind of event triggered could help (and TVs developers would be able to handle what it takes to enable/disable their TVs).

sebastian-marinescu commented 8 years ago

:+1: Just came across this problem...