modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 528 forks source link

[Meta] Improving the MODX documentation system #12864

Closed adamwintle closed 8 years ago

adamwintle commented 8 years ago

Summary

The current MODX Docs (RTFM) have a lot of room for improvement. I wanted to discuss what people think are the best ideas for a better MODX Docs and how we can go about implementing those improvements.

Here's a list of features I'd like to see added to the MODX Docs:

Those are just some ideas.

Since they are currently built on top of MODX it makes them very flexible, the easiest first step would be to version control this into git (using something like Gitify https://github.com/modmore/Gitify) so anybody can start making Pull Requests (without the system requiring a login to edit and request-only access).

Alternatively maybe MODX isn't the best platform for the docs, something else entirely could be better.

I'd also like to see some guidelines; perhaps it can be officially recommended that third-party plugins use their own Github pages for their docs, and the MODX Docs are kept for core subjects. That would help keep things focused and maintainable. A lot of the third-party plugins in the MODX Docs are out-of-date and more recently developers have just been setting up their own docs anyway. (e.g. http://bruno17.github.io/MIGX/, http://sepiariver.github.io/cssSweet/ and http://docs.modx.pro/ to name just three)

TL;DR. Overall the MODX Docs aren't the best they can be; let's improve them.

jaygilmore commented 8 years ago

The reason we built them in MODX at the time was:

I now think GitHub is fine however, I don't think PRs will speed things up. I think they will slow things down. RTFM is essentially being used as a wiki with controlled access. If you get access (we give access to nearly every person that asks), you can make edits anytime you'd like. If this gets put into a GitHub project, who's going to manage PRs? For less technical folks or perhaps a developer who uses Mercurial or SVN for their VCS submitting git PRs is a potential hurdle.

I don't know what you mean by entirely open? RTFM access has been granted to almost every single person who has ever asked.

I should say, that for users, the do not wish to be trolling github for various and sundry extras documentation. They want to go to the single source. This has been asked over and over through the years. People do not want to hunt down other sites.

I'd suggest that the problems with the docs have to do with quality control and ongoing management and a lack of an author's guide. I could support a forkable version controlled version but I'd love to also have non technical editors be able to make changes without having to submit a PR. On the PR front, who's going to review and admit the PRs. Open Source projects need management.

Currently, people are free to make any and all changes they'd like, just by logging in. If PRs are needed, then someone's going to have to review and accept them. While the quality will possibly improve, I can't see how the frequency of change could overcome that management bottleneck.

Perhaps all the docs go to github but then there's the fragmentation issue. I'd still love them collated and output on a site together so people could go to docs.modx.com and find the info they are looking for. Taking people away from the modx.com domain can be a small trust breaker for those less familar with GitHub. We need to keep in mind that the documentation is not just for developers, designers and site builders, but for marketing interns, hobbyists, small business owners with a little technical knowledge but needs reference.

TL;DR: The docs as they are now are not a closed system and that conversation is a red herring to making better docs. Github is fine but remember what documentation is and who it's for.

PS: There is a whole project on the MODX Documentation: https://github.com/modxcms/docs

jpdevries commented 8 years ago

There are over 100 Issues open at https://github.com/modxcms/docs/issues right now and most of them seem to be edit suggestions, with links to RTFM. It seems people don't have access to RTFM (maybe haven't even asked?) but are comfortable using Github issues.

If this gets put into a GitHub project, who's going to manage PRs?

This is a valid concern. Don't want PRs getting too stale. We use a PR workflow for submitting edits to Thinkful courses and sometimes it can be like yeah for my edit that will never be merged! If the docs were in a separate repo though it seems like people could be given push access to the docs without push access to the codebase right?

I remember really hoping to use the HTML5 API do add offline support to the docs, but never got there. I do wonder if it would be possible to integrate RTFM into the Dash app https://kapeli.com/dash

(update) I just had another look at Dash and it looks really but something more for documenting MODX itself (not just hosting RTFM offline). In other words, Dash is for APIs, although there may be a way to include RTFM docs under 'Plugins'. Dash has Wordpress and all sorts of other popular libraries, would be great to represent MODX!

pixelchutes commented 8 years ago

@jpdevries I use this on occasion: https://github.com/Kapeli/Dash-User-Contributions/tree/master/docsets/MODX

dash_modx onusersave
jpdevries commented 8 years ago

@pixelchutes nice! I didn't see that one. downloading.

Looks like it has some duplicate entries and doesn't include Extras.

pixelchutes commented 8 years ago

Yeah, it's a bit outdated, too...but a step in the right direction!

Mark-H commented 8 years ago

I'm closing this issue here in the interest of keeping these issues dedicated to Revo. Please feel free to continue discussing at https://github.com/modxcms/docs