modxcms / revolution

MODX Revolution - Content Management Framework

https://modx.com/

GNU General Public License v2.0

1.36k stars 528 forks source link

Package Manager modal popup doesn't display right title during download #13503

Closed devlanda closed 7 years ago

devlanda commented 7 years ago

Summary

The Package Manager modal popup doesn't display right title.

Step to reproduce

Without page reloading I installed multiple Extra's, like FormIt, TinyMCE Rich Text Editor and pdoTools. Thereafter, I downloaded package 'Collections'. In the console window title (modal popup) it displays still the title of installing FormIt.

Observed behavior

Wrong title is displayed in console window title (modal).

Expected behavior

It should display the title 'Please wait...'.

Environment

MODX 2.5.8-dev Apache 2.4.25 PHP 7.1.6 MySQL 5.7.18 Browser Chrome

gpsietzema commented 7 years ago

modxbughunt #1point to @devlanda

This was only related to sterc-extras right?

devlanda commented 7 years ago

I guess that is a different error. I will try that too.

rtripault commented 7 years ago

I'm able to reproduce on 2.x with FormIt. I believe this is related to installation/setup options (trying to validate that idea)

Edit : apparently wrong idea... checking the code!

rtripault commented 7 years ago

Here is the issue https://github.com/Sterc/FormIt/blob/develop/_build/setup.options.php#L50

Somehow not related to the core (albeit a fix could probably be provided)

gpsietzema commented 7 years ago

Thanks @rtripault

modxbughunt #1point to @rtripault