search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

Saving a page containing an image does not work in firefox #13624

Closed janwidmer closed 6 years ago

janwidmer commented 7 years ago

Summary

When saving a page after adding an image, the loading bar stays forever because a JS Exception happens. The Problem only occurs in Firefox (vs 56) on Windows (10)

Step to reproduce

  1. Open a page in the manager
  2. Add an image within the content or as a template variable
  3. click on the save button

Observed behavior

The loading bar stays forever, the changes do not get saved. The following js error is thrown in the console: modx-tiny-mce-error

Expected behavior

The saving works

Environment

MODX version 2.5.8, Apache/2.4, mysql version 10.1-MariaDB, Firefox vs. 56, Windows 10

Mark-H commented 7 years ago

This appears to be a tinymce issue. Had a modmore client last week with the same issue, and there's a few forum posts about it, but other than advising to switch to a different RTE I haven't found a fix for it yet.

Op 3 okt. 2017 1:25 p.m. schreef "Jan Widmer" notifications@github.com:

Summary

When saving a page after adding an image, the loading bar stays forever because a JS Exception happens. The Problem only occurs in Firefox (vs 56) on Windows (10) Step to reproduce

  1. Open a page in the manager
  2. Add an image within the content or as a template variable
  3. click on the save button

Observed behavior

The loading bar stays forever, the changes do not get saved. The following js error is thrown in the console: [image: modx-tiny-mce-error] https://user-images.githubusercontent.com/3381820/31122809-9da1caae-a83d-11e7-8fed-9d7af9819052.png Expected behavior

The saving works Environment

MODX version 2.5.8, Apache/2.4, mysql version 10.1-MariaDB, Firefox vs. 56, Windows 10

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/modxcms/revolution/issues/13624, or mute the thread https://github.com/notifications/unsubscribe-auth/AATGcBRLo8XtA2Ef41ANQNsg5Jotmb9iks5sohmTgaJpZM4Pr9f1 .

OptimusCrime commented 7 years ago

Indeed. This does not look like a MODX core error. Is this the TinyMCE or tinymce-rte extra?

matdave commented 6 years ago

Indeed. This does not look like a MODX core error. Is this the TinyMCE or tinymce-rte extra?

It looks like old TinyMCE, @janwidmer I would recommend upgrading to the new TinyMCE RTE. It works much better in modern browsers.

janwidmer commented 6 years ago

ok I will see if I can do an update

alroniks commented 6 years ago

Closing because it's unrelated to MODX directly. Feel free to reopen.