modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

editedon and editedby fields aren't updated after a resource deletion or undeletion #13673

Closed aaaatpdev closed 6 years ago

aaaatpdev commented 6 years ago

Summary

editedon and editedby fields in site_content table aren't updated after a resource deletion or undeletion.

Step to reproduce

  1. Delete a resource
  2. Undelete the resource
  3. Watch editedon and editedby fields of the resource in the database

Observed behavior

editedon and editedby fields in site_content table aren't updated after a resource deletion or undeletion.

Expected behavior

Update of editedon and editedby fields in site_content table after a resource deletion or undeletion.

Environment

MODX Revolution 2.6.0-pl

bezumkin commented 6 years ago

But deletion and undeletion is not really an update of resource. You just change the deleted flag in table.

So I believe, everything works as expected.

gpsietzema commented 6 years ago

@modxbot close

aaaatpdev commented 6 years ago

The resource field deleted is the same field as published or hidemenu. After their change editedby and editedon are updated. So i think that after deletion or undeletion of a resource editedby and editedon should also be updated