search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

Remove flash (.swf) based copy to clipboard #13697

Closed OptimusCrime closed 6 years ago

OptimusCrime commented 6 years ago

Summary

MODX is shipped with a Flash file. This is used to set up the old way of doing "Copy to clipboard". This functionality was in MODX before, but has since been removed. I see no traces of this functionality anywhere but lexicon entries and changelogs. I think we can remove this and get rid of the Flash file once and for all.

Edit: Actually, MODX is shipped with more Flash files. I do not know if these are in use. This issue only concerns the clipboard one.

Environment

Current version c2466999ddc527186d7855330bb5562901d23001

rthrash commented 6 years ago

Some possibly useful things to help evaluate:

Quick search everywhere the fileAPI is referenced: https://github.com/modxcms/revolution/search?utf8=%E2%9C%93&q=fileapi&type=

How to banish the flash bits on the fileAPI itself and only use HTML5 methods: github.com/mailru/FileAPI

(Speaking of which looks like we're more than a few versions behind on that dependency…)

OptimusCrime commented 6 years ago

Thank you for doing your research @rthrash :) Nice to have written down for later. Worth pointing out that this issue only concerns the other swf file though.

JoshuaLuckers commented 6 years ago

This issue may be closed.