Closed gadgetto closed 5 years ago
My PR should fix it, but it still not merged into current 3.x https://github.com/modxcms/revolution/pull/13888
BTW, the extra doesn’t install properly!
It is merged now. Can you try again?
I've installed the downloadable build. I'm a composer noob (command line noob in general) so I need to wait until updated build is available order integrate the changes manually...
@gadgetto Try this https://cloud.2head.ru/s/iRbxnxcNwXHTzc6
Hey cool! Thanks!
Is this the full or composer build?
@gadgetto Full archive with everything needed.
Just extract and run setup.
Thx!
OK, with the merged PR it now installs fine! But the CMP doesn't load. I get an:
Uncaught TypeError: Cannot read property 'createChild' of null
at Ext.Toolbar.onRender (ext-all.js:21)
at Ext.Toolbar.render (ext-all.js:21)
at Ext.Toolbar.Ext.Component [as constructor] (ext-all.js:21)
at Ext.Toolbar.S [as constructor] (ext-base.js:21)
at Ext.Toolbar.S [as constructor] (ext-base.js:21)
at new Ext.Toolbar (ext-all.js:21)
at GoodNews.HomePanel.init (home.panel.js:59)
at new GoodNews.HomePanel (home.panel.js:55)
at Object.create (ext-all.js:21)
at S.createComponent (ext-all.js:21)
Seems the actionToolbar
handling has changed...
I'm overwriting this method: (GoodNews has a custom action toolbar)
init: function(){
this.actionToolbar = new Ext.Toolbar({
renderTo: 'modAB'
,id: 'modx-action-buttons'
,defaults: { scope: this }
,items: this.getElements()
});
this.actionToolbar.doLayout();
}
Moving discussion about this to slack channel: https://modxcommunity.slack.com/messages/C6FCUJT55
@gadgetto Error corrected earlier.
@Alroniks I vote for closing this problem.
Attempting to install package with signature: goodnews-1.5.1-pl2
Package found...now preparing to install.
Grabbing package workspace...
Workspace environment initiated, now installing package...
modAction support is deprecated since version 2.3.0. Support for modAction has been replaced with routing based on a namespace and action name. Please update the extra with the namespace goodnews to the routing based system.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Added "GoodNews" to extension_packages system setting.
Database Tables Resolver - creating database tables...
Existing tables will be skipped!
-> creating table: `modx_goodnews_mailing_meta`
-> creating table: `modx_goodnews_recipients`
-> creating table: `modx_goodnews_subscriber_meta`
-> creating table: `modx_goodnews_subscriber_log`
-> creating table: `modx_goodnews_groups`
-> creating table: `modx_goodnews_group_members`
-> creating table: `modx_goodnews_categories`
-> creating table: `modx_goodnews_category_members`
-> creating table: `modx_goodnews_processes`
Tables Content Resolver - creating some database entries in custom tables...
Resource Resolver - installing sample Resource documents...
-> installed sample Resource document: GoodNews Subscription Confirm
-> installed sample Resource document: GoodNews Subscription Mail Sent
-> installed sample Resource document: GoodNews Subscription Success
-> installed sample Resource document: GoodNews Subscription Update
-> installed sample Resource document: GoodNews Profile Update
-> installed sample Resource document: GoodNews Subscription
-> installed sample Resource document: GoodNews Unsubscribe
-> installed sample Resource document: GoodNews Request Links
-> installed sample Resource document: GoodNews Registration Confirm
-> installed sample Resource document: GoodNews Registration Mail Sent
-> installed sample Resource document: GoodNews Registration
-> installed sample Resource document: GoodNews Terms and Conditions
-> installed sample Resource document: GoodNews Privacy Policy
Custom Resource Resolver - installing custom Resource documents...
-> installed custom Resource document: GoodNews
Plugin Event Resolver - assigning Plugin events...
-> assigned Event OnManagerPageInit to Plugin GoodNews
-> assigned Event OnUserRemove to Plugin GoodNews
Successfully installed package goodnews-1.5.1-pl2```
Summary
Tried to install a 3rd-party package (my add-on GoodNews latest version 1.5.0) manually via upload. The install log freezes and there is a message:
Could not load class: xPDOTransport from transport.xpdotransport
Environment
MAMP site with SSL enabled MODX version: 3.0.0-dev
The package just installs fine in MODX 2.6.4-pl.
Do we need to change install scripts? What has changed in MODX3?