search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

License type of the repo not detected #14023

Closed JoshuaLuckers closed 5 years ago

JoshuaLuckers commented 6 years ago

Summary

As noted by @OptimusCrime in PR #13993 the repo is not showing the license being used.

More info about licensing a repo can be found here.

Step to reproduce

Check the tabs of this repo.

Observed behavior

No tab with the license being used.

Expected behavior

A tab showing the license being used.

Environment

GitHub

OptimusCrime commented 6 years ago

I am pretty sure it happens because GitHUb detects that the text is not identical to the template.

JoshuaLuckers commented 6 years ago

GitHub scheduled it to be redetected. Sadly it did not seem to work and I've contacted GitHub Support about it.

OptimusCrime commented 6 years ago

Any news about this?

JoshuaLuckers commented 6 years ago

Someone will get back to me soon.

JoshuaLuckers commented 6 years ago

Support mailed me back:

If your repository is using a license that is listed on the Choose a License website and it's not displaying clearly at the top of the repository page, it may contain multiple licenses or other complexity. Our team wrote more abut this here: https://help.github.com/articles/licensing-a-repository/#detecting-a-license

My guess is that our systems are also detecting that COPYRIGHT file in the root: https://github.com/modxcms/revolution/blob/2.x/COPYRIGHT

Could you move that file into its own folder and see if that helps detect the LICENSE in the top right corner?

Ping @opengeek

OptimusCrime commented 6 years ago

Do we need both a copyright and a license?

Jako commented 6 years ago

@JoshuaLuckers Is it possible to check that on your fork?

alroniks commented 6 years ago

I've experimented on my own repo (see last commits https://github.com/Alroniks/modx-foo-bar-extra/commits/master) and removing copyright file solves the issue. I've tried to repeat the full cycle with files in MODX repo: created copyright file at first, after created license file with some strings of text, after selected GPL v2 license from suggested by GitHub during editing the file, and nothing happened. But when I removed copyright file - license mark appeared.

JoshuaLuckers commented 6 years ago

Thanks for testing @Alroniks! If we remove the copyright file the copyright headers have to be modified again..

OptimusCrime commented 6 years ago

Would they? Why? The license say the same as the copyright doesn't it?

opengeek commented 6 years ago

WTAF!?

JoshuaLuckers commented 6 years ago

@OptimusCrime in the file headers there are references to the LICENSE and COPYRIGHT file.

@opengeek Can we remove or move the COPYRIGHT file?

JoshuaLuckers commented 5 years ago

There is a view license tab now. I’m fine with the solution we have now.