modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

Show a link to edit an item in its name in the MODX tables #14125

Closed Ruslan-Aleev closed 4 years ago

Ruslan-Aleev commented 5 years ago

In MODX many settings are edited via the context menu, but this is not obvious, especially if you are not familiar with MODX. For example in "Context" settings: clicked on the row - nothing happened, clicked 2 times on row - nothing happens either.

How I see it: link_2

I think links should be added to all such tables, this is more understandable for the user than the context menu. p.s. By the way, in the "Manage -> Users" section the links are already made, but only it is not visible until you hover on it.

Also a good variant with icons suggested by @Jako:

Done with https://github.com/modxcms/revolution/pull/14806

icons_2

Jako commented 5 years ago

We should better add a button column like in SwitchTemplate to all grids in the manager. The 'real' links of some manager pages should be inserted there too (to make those buttons be clickable with a command-click/controll-click while opening the link in a new tab).

Screenshot:

bildschirmfoto 2018-10-29 um 12 30 15
Ruslan-Aleev commented 5 years ago

@Jako Yes, the icons are also useful, but the links on the names of the lines are more noticeable and understandable. Ideal variant - make and links on names and icons.

Jako commented 5 years ago

Some grids could be edited inline and the links can't be used there, so we would have different UX for inline grids, which is a bad habit.

Ruslan-Aleev commented 5 years ago

@Jako In the "System settings", for example, inline editing, a window pops up by clicking on the link. The goal is not to change the functional, but to copy the link from the context menu to the name, the functional already exists. Or are you talking about something else, you can specify an example of inline editing?

Jako commented 5 years ago

If you i.e. double click the name of a context in your example above, the value could be edited inline without a popup. Thats not possible anymore, if the name is surrounded with a link, like you want to do.

Jako commented 5 years ago

Example:

bildschirmfoto 2018-10-29 um 13 17 05
Jako commented 5 years ago

You could also directly edit the value of the system setting with a double click.

Ruslan-Aleev commented 5 years ago

@Jako Yes, you are right, the context name cannot be changed in this way, but on a page (when clicked), the name can be changed (for other table elemets in a pop-up window). Here the question is what is more important and changes more often: the name of the context or the context setting (i think the settings)?

And in the system settings it’s true that by double-clicking the value changes, but for a new MODX user, this is not at all obvious, and it’s not obvious how to go, for example, to the context settings (double-clicking here will not work).

We need to think about it, but it seems to me that the benefits of links are more than the ability to quickly change the name. Button column is also good variant, but, in my opinion, the icon will be less noticeable, especially in large lists and moving the mouse to the button at the end of the line is also uncomfortable. Correctly move the button to the beginning of the line.

In any case, we need a more discussion :)

Jako commented 5 years ago

Both options (inline editing and no right click) could be possible with a button column.

Jako commented 5 years ago

@gpsietzema Could you add this to the UX change requests for MODX3?

Ruslan-Aleev commented 5 years ago

@Jako By the way, the name through a double click can be changed, even if there is a link (we discussed above), you can test PR https://github.com/modxcms/revolution/pull/14581

Ruslan-Aleev commented 5 years ago

Related with https://github.com/modxcms/revolution/issues/13780

Mark-H commented 4 years ago

Resolved with a new actions column / gear icon automatically added to grids in #14806

Ruslan-Aleev commented 4 years ago

@Mark-H I wanted to start adding links to the name in grids in the future, as for example, now in the /manager/?a=security/user section. I think it’s worth reopening this issue. The new gear menu is cool, but with a link there will be less unnecessary clicks, more useful for UX.

JoshuaLuckers commented 4 years ago

It would be great if you add a task list with work that still needs to be done before we can consider this issue solved.

Ruslan-Aleev commented 4 years ago

I think we can close this issue. Done with PR https://github.com/modxcms/revolution/pull/14864 and https://github.com/modxcms/revolution/pull/14806