Closed catsmeatman closed 5 years ago
~Strange - when I view the max-width
for #modx-topnav
it is set in pixels (1200px which equates to 75em).~
~Could this be a problem caused by your custom manager theme perhaps?~
@jonleverrier I updated the pure MODX 2.6.5 to 2.7 - the problem is in place. I use Windows 7, checked in last Chrome and Firefox.
Does clearing the browser cache help?
@JoshuaLuckers It did not help me. The problem may be: 1) due to the fact that MODX was updated to 2.7, and not installed cleanly. 2) is Windows OS.
In fact, after clearing my cache, I can see that max-width
is set to 68em not 1200px! So ignore my previous comment :)
I can't quite pin it down.
Looks like something happened to the generated css during this commit: https://github.com/modxcms/revolution/commit/f5840eeba313bda24feafa9cb01874b72243303b#diff-7e2c7fd904a55c9f817302cebbcaf068
Any ideas @Jako ?
Looks like it comes from some library that was updated.
Hmm, some grunt process is running mad. It removed the :not
css rules too.
Does anyone have a quick fix for this issue?
It might cause other issues but for now I've just changed line 2345 in index.css from max-width:68em;
to max-width:100%;
.
I tried to fix over the weekend, but I can’t find any reference to max-width
on #modx-topnav
in the SASS files in the 2.x branch.
Any ideas where that property is coming from @jako ?
@ibochkarev - I looked at that file. No reference to max-width
on #modx-topnav
!
@jonleverrier Sorry, did not finish reading
The template uses node-neat and bourbon. If I am right it is caused by node-neat.
Thanks @Jako - that makes sense now.
Before I try and fix, If I compile the CSS locally, the max-width
value on #modx-topnav
is set correctly to the old value of 1200px and not 68em?! Should that be the case?
Could you look if the missing :not (i.e. in https://github.com/modxcms/revolution/commit/f5840eeba313bda24feafa9cb01874b72243303b#diff-7e2c7fd904a55c9f817302cebbcaf068L4183) rules are there in your compiled css? Then we have to solve a compilation issue on integrator side.
@Jako They are not missing in my generated CSS! So like you say, looks like it could be a compiling issue.
If I remember right, then I did not notice a CSS change, when I compiled the CSS on my installation after the bower removement. So it should be a compiling issue.
@jonleverrier Which versions of nodejs and npm did you use?
@Alroniks I'm using:
I can't remember precisely, but I either had some problems with building the MODX CSS or there was a conflict with my other build tools, so had to down grade.
I have the same issue, running more updated versions of node and npm:
~/.../templates/default/css on 2.x $ node -v
v10.13.0
~/.../templates/default/css on 2.x $ npm -v
6.4.1
@Alroniks @Jako
I've just updated to the latest version of node.js:
I managed to compile the CSS without any errors (plenty of warnings!). The max-width
on #modx-topnav
is still set to 1200px (not 68em which is causing the issue).
However, the missing :not
(https://github.com/modxcms/revolution/commit/f5840eeba313bda24feafa9cb01874b72243303b#diff-7e2c7fd904a55c9f817302cebbcaf068L4183) are still missing.
@OptimusCrime Yes, I have the same versions and recompiling does not give me an any changes (it means that issue still there). So it's a problem.
@Alroniks you do properly clean the env before running the build?
rm -rf node_modules && npm i && grunt build
@OptimusCrime Yes, nothing. Weird.
It is a sass compiling issue (the :not rules are away after grunt sass), but I had no time to locate this.
The :not rules are removed by libsass: https://github.com/sass/node-sass/issues/2330. So we have to wait for a fix there.
Summary
New menu item not fit in top horizontal menu
Step to reproduce
Observed behavior
this is caused by #modx-topnav {max-width: 68em;}
Environment
MODX 2.7-advanced