search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

Double load for TV media sources list #14966

Closed ant-tar closed 4 years ago

ant-tar commented 4 years ago

Bug report

Summary

User should click twice on source selectore while changing media source for TV

Step to reproduce

  1. Create second media source (additionally to default one).
  2. Open any TV and try to change appropriate media source via Media Sources tab

Observed behavior

Please check this:

media_source_double_load

Expected behavior

Better UX - list should be loaded only once after click OR preloaded initially somehow. Single click should allow to open the list and select another source anyway.

By the way, there are no problems in "System settings" with the choice of the sources.

Environment

MODX 2.7.2

Ruslan-Aleev commented 4 years ago

If we delete this line https://github.com/modxcms/revolution/blob/2.x/manager/assets/modext/widgets/element/modx.panel.tv.js#L669, then there is no double loading, but the source name is not displayed (only its id):

tv-sources

In the system settings and other elements in manager grids only id is displayed. For the UI, hiding the name is a minus, but the lack of double loading is a huge plus :)

Can we leave id output @theboxer , what do you think?

p.s. Most likely, many will not notice the changes, but the double loading bug is extremely annoying.

Jako commented 4 years ago

@Ruslan-Aleev It is better to detect the bug than disabling an option.

Ruslan-Aleev commented 4 years ago

@Jako Thank you for helping with the bug! It’s clear that it’s better to fix the bug, no one argues. I just suggested a quick solution. Moreover, a similar behavior is already found in the "System settings". In my opinion, a crooked solution is better than an ideal one, but somewhere in the distant future... p.s. I would fix the bug correctly if I knew how :)

Jako commented 4 years ago

Moreover, a similar behavior is already found in the "System settings".

Could you give an example?

Ruslan-Aleev commented 4 years ago

I meant that the name of the media source is not displayed:

source_setting

Ibochkarev commented 4 years ago

Fixed #15122

@himurovich Thanks for taking time to report this issue and help make MODX better. Please reopen if you still encounter this issue.

@modxbot close

Jako commented 4 years ago

@Ruslan-Aleev Could you open a feature request for your issue?