Problem when there is several active Sets in the Form Customization

[Spheerys]

spheerys created Redmine issue ID 3749

I have found an anomaly when I trying to use several active Sets for a same profile, with the TV templates. The goal, is to customize the manager for a final user. The final user (Bob), has to only have the necessary fields when he's editing/creating a document. We are using TVs for the several type of documents.

Preparation to reproduce the bug :

• imagine there are 2 sorts of container documents : Stages (id=1) and Lessons (id=2)
• create two TVs :
  • StageDate (if you want in a category "Stage" because this TV is only for the Stages)
  • LessonPlace (if you want in a category "Lesson" because this TV is only for the Lessons)
• create the account for Bob and make all the right access permissions and role
• go to Security > Form Customization
• create a new profile "End User" and edit it
• create a new Set in "Stage Creation" with the good parameters, for the same Template (I suppose I don't have to explain everything here)
• connect yourself with Bob and try to create a stage : everything should be OK : you can see the TV tab with the StageDate TV
• if yes, return in the Form Customization and duplicate the "Stage Creation"
• rename it "Lesson Creation" and edit it to change the good TV, the parent targeted etc...
• desactivate the "Stage Creation" Set and activate the "Lesson Creation"
• with Bod account, try to create a new lesson and verify if the good TV is accessible (and only it)

So normaly everything is ready to reproduce the bug :

• return in the Form Customization and activate the both Sets
• with Bod account, try to create a Stage and verify if the good TV is accessible
• if yes, create now a new Lesson. The LessonPlace TV is not accessible while it should !

[modxbot]

romain submitted:

A workaround would be to let TVs visible for all users, hide the TV panel/tab, create new tabs for each users (showing the needed ones to the proper user) and move TVs to appropriate tab

[Spheerys]

spheerys submitted:

Is this bug will be resolved for the 2.1.0-pl ?

The result of this bug is to generate confusion on the edition of the TVs for the final user : there are all the TVs tabs during the edition, instead of the Tabs link directly to the document.

[Spheerys]

spheerys submitted:

Hummm... am I the only one to have this problem ?

Is my procedure to reproduce the bug is not efficient ?

Please, just say a word !!! :)

[modxbot]

romain submitted:

« a word »… ok, i promiss i won't do it again. By the way, did you check if that's still occuring with the latest Revolution build (2.1.1-pl) ?

[Spheerys]

spheerys submitted:

yes of course, with the last 2.1.1-pl the bug is still occuring... that's why I have reactivates this bug report :)

[Spheerys]

spheerys submitted:

I'm a little bit disapointed by the silence here... Maybe my explains were not clear and nobody should reproduce the bug. But in this case, you can tell it !

Please tell me what's wrong with my bug repport !

Thanks :)

[hugopeek]

Will try to reproduce this bug during #modxbughunt.

[hugopeek]

OK, I think I figured out the scenario that TS described:

• Created Editor user group
• Created user Bob in Editor group
• Create FC set "For Bob" that hides a certain TV for the Editor group
• Confirm that it works: TV visible for admin, TV hidden for Bob
• Duplicate the entire For Bob profile (so not just the set)
• Hide a different TV from the Editor group (and set the first one to "visible" again)
• Confirm that it works
• Enable both profiles

This results in both TVs not being displayed. I tested it with Pagetitle, with the same result.

Conclusion: the "hidden" state is dominant for the visibility toggle. If an element is present in multiple FC profiles, and visibility is unchecked in one of them, the element will remain hidden.

But is this a bug? If you turn this around and always make an element visible if it's checked, you can run into the exact same scenario in reverse, where a user could argue that the decision to hide a certain element is not being respected.

I suggest we describe the current behaviour a bit more pronounced in the MODX docs and on top of the FC grid. That way, users will know what to expect.