search

modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

Add "Allow Blank" setting to all TV input type #6521

Closed modxbot closed 4 years ago

modxbot commented 12 years ago

yogooo created Redmine issue ID 6521

Add the "Allow Blank" setting to all TV input type. Currently unavailable for type :

I'm currently setting up a website where non-empty images and url TVs are required. "Allow Blank" is a super useful option and it would be even more helpful if it was available for all TV types.

SiarAneas commented 10 years ago

Interesting enough, this still seems to be an issue... and also a major drawback as I can only agree, that this feature is very important... I would definitely like to vote for this one! Are there any workarounds to get this working (now in 2.3)? (especially with images...)

exside commented 10 years ago

Definitely something I'm gonna look into, miss a few settings myself...for example I made the "thumb" of the image tv significantly bigger in the 2.3 theme, but maybe somebody doesn't like that, so there should be a setting to configure the thumb dimensions of an image tv =)...

also related: https://github.com/modxcms/revolution/issues/11759

JoshuaLuckers commented 7 years ago

Is there any progress on this issue?

JoshuaLuckers commented 5 years ago

After doing a bit of research I leave this here as a reference.

The file and image TV use the modx-combo-browser xtype manager/assets/modext/widgets/core/modx.combo.js.

The component MODx.combo.Browser extends Ext.form.TriggerField and has support for allowBlank: false. However setting allowBlank: false in MODx.combo.Browser marks the input field as "invalid" because it's empty when rendered. Saving the resource is still possible even if the input field is blank.

Ruslan-Aleev commented 4 years ago

Does anyone have any ideas on how to fix it? TV in MODX is one of the coolest features and it is strange that TVs do not work correctly.

JoshuaLuckers commented 4 years ago

Thanks for reminding me, I'll put it back on my todo list!

JoshuaLuckers commented 4 years ago

Thanks @Ruslan-Aleev !