modxcms / revolution

MODX Revolution - Content Management Framework
https://modx.com/
GNU General Public License v2.0
1.36k stars 529 forks source link

modResource::refreshURIs sortby #9562

Closed Fi1osof closed 9 years ago

Fi1osof commented 11 years ago

fi1osof created Redmine issue ID 9562

$criteria->sortby('menuindex', 'ASC') not necessary, but create highload if many resource in table.

pixelchutes commented 9 years ago

@opengeek do you know if the sort here is required to function correctly?

opengeek commented 9 years ago

it is absolutely necessary — the resourceMap and aliasMaps are expected to have the resources sorted by menuindex

opengeek commented 9 years ago

In fact, I think this is a non-issue now; IIRC we added an index to speed up the query and reduce load since this was suggested.