search

modxcms / tinymce-rte

GNU General Public License v2.0
14 stars 23 forks source link

max_height setting does not work #126

Closed sentience closed 1 year ago

sentience commented 2 years ago

Bug report

Summary

With the default configuration of the autoresize plugin enabled, the tinymcrte.max_height setting is intended to limit the maximum height that the editor field can automatically expand to. It does not do this; the setting does not appear to do anything.

As a work-around, setting tinymce.settings to {"max_height": 500} does work. I therefore suspect that the issue is that the value is being interpreted as a string rather than a number.

Step to reproduce

Test with the default configuration, tinymcerte.max_height = 500 and tinymcerte.plugins = autoresize ….

Open a page for editing and add a bunch of blank lines to the end of the content.

Observed behavior

The editor field auto-resizes without limit.

Expected behavior

The editor field should max out at 500 pixels, and add a scrollbar past that point.

Environment

MODX 2.8.4-pl, Chrome 105.

Jako commented 1 year ago

Thanks for reporting the issue. Fixed with 2.0.9