search

modxcms / tinymce-rte

GNU General Public License v2.0
14 stars 23 forks source link

TinyMCE Version 6/7 #133

Open atorockio opened 1 year ago

atorockio commented 1 year ago

Feature request

Summary

Since TinyMCE is soon ending support for version 5, are there any plans to upgrade this package to TinyMCE 6?

Why is it needed?

TinyMCE 5 support is ending in April. It doesn't seem urgent to upgrade but I wanted to see if there is any plan, or interest here.

Suggested solution(s)

This is the documentation on how to upgrade to TinyMCE 6. I'm not sure what else would need to be upgraded.

jenswittmann commented 1 month ago

Are there any plans to update to TinyMCE 6 or 7 in the next few weeks? Would be nice for the manager accessibility: https://github.com/modxcms/revolution/issues/16612

jenswittmann commented 1 month ago

@Jako I am trying to build a version with TinyMCE 7. Changing the TinyMCE core works fine, but both MODX related plugins need an update to the new JS API calls.

But now I am wondering about the licence key. Do you have more info on this? Is this a reason to stick with version 5?

Jako commented 1 month ago

Feel free to add the new TinyMCE version here.

Both plugins are needed somehow. I have added the original and the patched code in src/modx/plugins/modximage and src/modx/plugins/modxlink to make it easier to follow the needed changes in version 5. This is different in version 6 and/or 7.

Since TinyMCE RTE is licensed with the GPLv2, you just have to add a line to the initialization: https://www.tiny.cloud/docs/tinymce/latest/license-key/#use-tinymce-with-the-gplv2-license

There were two reasons not to update to TinyMCE 6 or 7 for me: Some useful plugins are now commercial. Both plugins have to be updated and the link plugin is somehow limited by this issue: https://github.com/tinymce/tinymce/issues/6588

jenswittmann commented 1 month ago

Thank you @Jako for these insights! I'm trying TinyMCE 7 and don't notice any better accessibility than in version 5 for the MODX manager. So I think we have no pressure to update to TinyMCE 7 at the moment. I think making these points public is important for everyone looking for the new version.