modxcms / xpdo

xPDO Object Relational Bridge for PHP
http://xpdo.org/
GNU General Public License v2.0
72 stars 53 forks source link

PHP 8.2 Deprecated Dynamic Properties when using getService #256

Open marcuspoehls opened 5 months ago

marcuspoehls commented 5 months ago

Bug report

Summary

Update to PHP 8.2 and watch your Modx log file. You’ll notice PHP deprecation warnings for dynamic properties in the xPDO class. This happens in xPDO when using the getService method because it dynamically assigns the named service to their instance. See https://github.com/modxcms/revolution/blob/45e4b239f72a2352e788e4f2a3c3f0f456a5e175/core/xpdo/xpdo.class.php#L1238

The deprecation log lines look like this:

Deprecated: Creation of dynamic property modX::$myCustomService is deprecated in /core/xpdo/xpdo.class.php on line 1238

Environment

MODX 2.8.7, PHP 8.2.16

sonicpunk commented 5 months ago

I can confirm this.