modxorg / Docs

MODX documentation in markdown
https://docs.modx.com/
28 stars 105 forks source link

Issue on extending-modx/modx-class/reference/modx.getservice #449

Open jgulledge19 opened 1 year ago

jgulledge19 commented 1 year ago

Affected page(s)

PHPStorm states that this method call, modx->getService() is depreciated and states it will be removed in 3.1.

What needs to be improved?

Please list it as depreciated and state how to update or the correct use for v3. This looks like a recommendation: https://github.com/modxcms/revolution/issues/15807#issuecomment-913505788

Relevant context

Would be helpful to note on https://docs.modx.com/3.x/en/getting-started/upgrading-to-3.0 and https://docs.modx.com/3.x/en/getting-started/upgrading-to-3.0/class-names.

Mark-H commented 1 year ago

This will not be removed in 3.1. It was intended to be replaced fully by the new container but is still used too much, including by core itself.