Closed jghibiki closed 3 years ago
Test Coverage is up to 70%, new plugins are fully tested.
@dekarrin Any idea why the build would be failing as it is on the git clone step?
Hm, well the clone step worked this time. Must have been a temp. problem.
:tada: build finally succeeded!
@dekarrin whenever you have some free time, i think this is ready for review.
Please reference an issue, or fill out the below information
Adds a notification plugin, with back-ends for pushbullet, email, and slack (the underlying library notifiers supports additional platforms).
Also updates the Server API system to add a ServerResponse object to better standardize the responses from the plugin/builtin server api hooks.
Also refactors the IntenEvent system to have it's own builtin. Added a handler that will take an Intent object and convert it to a typed Event subclass object that can be submitted to the event bus. This allows plugins and builtins to be loosly coupled as a builtin or plugin can create an intent which will be converted to a required typed event that another builtin or plugin can handle.
e.g.
For example to trigger a notification via the notification plugin via the cli (requires that the notification plugin is configured, and configured to be loaded in the msa_config.json):
❗️🖊 If you have not yet, please sign our Contributor License Agreement. Your PR will not be accepted until we have confirmed that you have signed.