search

moehmeni / syncedlyrics

Get an LRC format (synchronized) lyrics for your music
MIT License
239 stars 23 forks source link

📋 Add copy to clipboard flag (--clipboard) feature #32

Closed NikitaBeloglazov closed 4 months ago

NikitaBeloglazov commented 4 months ago

Often, users of this CLI, after using the command, begin to select text and copy it to paste it into some ID3 editor application (for example, KID3). Because I use this CLI myself, I decided to add some contribution to this application ☺️

By specifying the -c flag or the --clipboard flag, at the end of the work the song lyrics will be automatically copied to the clipboard for user's further interactions. So easy

This is my first serious PR I will be glad if this PR will be merged ^^.

Thanks for this wonderful project :3

moehmeni commented 4 months ago

Hi, thanks for your contribution! I appreciate it. Can you please run poetry lock --no-update so the tests can be done. I was trying to fix it and then realized you should change the .lock file because you added a new package to the poetry file. Maybe that will fix test issues.

moehmeni commented 4 months ago

It seems clipman uses python >=3.9 which is not compatible with syncedlyrics' python >= 3.8. Until further changes from clipman to support 3.8, the PR is reverted.

feel free to support 3.8 in your package, and then re create the PR. also it would be good to mention what are the benefits of having such option while the user can use

right in terminal.