moehmeni / syncedlyrics

Get an LRC format (synchronized) lyrics for your music
MIT License
239 stars 23 forks source link

No Github release for 0.10.1 #40

Closed pekkarr closed 4 months ago

pekkarr commented 4 months ago

The latest version on PyPI is 0.10.1, but the Github release and git tag for that version is missing. Currently the latest Github release is 0.10.0.

Could 0.10.1 be added to the releases as well?

moehmeni commented 4 months ago

Since it was only a small bug fix and just after the 0.10.0 release I did not post it and mentioned the change in the end of that release. Is it important for something?

On Mon, May 27, 2024 at 12:34, pekkarr @.***(mailto:On Mon, May 27, 2024 at 12:34, pekkarr < wrote:

The latest version on PyPI is 0.10.1, but the Github release and git tag for that version is missing. Currently the latest Github release is 0.10.0.

Could 0.10.1 be added to the releases as well?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

pekkarr commented 4 months ago

Thanks for the quick response!

Is it important for something?

For the Arch Linux AUR package we use the git tag to pull the correct source code archive from Github, as Github provides source archives automatically at https://github.com/moehmeni/syncedlyrics/archive/refs/tags/v${pkgver}.tar.gz. This requires that the repository has the specific version tag.

We could pull the source code using the commit ID as well, but version tags are easier to deal with for us.

Additionally, people might use tools like nvchecker to monitor the latest release of the software, and if nvchecker is configured to monitor Github releases it won't notice the new version (nvchecker can also be configured to get the version from PyPI which gives the correct version currently).

moehmeni commented 4 months ago

Thanks for explanation, I released v0.10.1 also on GitHub.

pekkarr commented 4 months ago

Thanks, the AUR package is now updated to 0.10.1