search

moehmeni / syncedlyrics

Get an LRC format (synchronized) lyrics for your music
MIT License
239 stars 23 forks source link

Requests don't time out for very long #43

Closed jmaximusix closed 4 months ago

jmaximusix commented 4 months ago

megalobiz.com seems to be currently down and I noticed there isn't an adequate timeout on the request, so the whole program gets stuck for a very long time (indefinitely?). I suggest adding a 5-10 second timeout on the requests.

jmaximusix commented 4 months ago

Since the change is trivial, I just went ahead and created a pull request #44 where I added a 10 second timeout. Feel free to adjust it to a different value, I just thought 10 seconds should be plenty of time for any working request to get an answer and still allow the program to continue within a reasonable timeframe, should the request fail.