moehmeni / syncedlyrics

Get an LRC format (synchronized) lyrics for your music
MIT License
188 stars 18 forks source link

No option to prefer synced, but allow plaintext lyrics #45

Closed jmaximusix closed 3 weeks ago

jmaximusix commented 1 month ago

The way the code currently works is that it returns as soon as it finds lyrics. If --allow-plain is set, this means that as soon as it finds plaintext lyrics on one provider it stops looking, even though another provider might have a synced version available. This contradicts the description of the --allow-plain argument, which suggests that plaintext is only used when no synced version is found.

I suggest differentiating between 3 different cases:

I think "prefer synced" would be the "default" option, as I imagine that's what most people want.

I'm currently trying to implement this for myself, looking to submit it as a PR later

moehmeni commented 1 month ago

Thank you sounds good. I would appreciate a PR, otherwise I will at least fix the bug mentioned about returning a plaintext as soon as we find it.