moehmeni / syncedlyrics

Get an LRC format (synchronized) lyrics for your music
MIT License
188 stars 18 forks source link

Prefer synced lyrics, options to allow only plain/synced #47

Closed jmaximusix closed 3 weeks ago

jmaximusix commented 1 month ago
jmaximusix commented 3 weeks ago

uhmmm... well that's unfortunate xD I just removed the print statement, now apparently they couldn't reach deezer? Can you somehow restart the tests or do they only run on commits?

moehmeni commented 3 weeks ago

Seems Deezer doesn't work anymore lol. I wanted to comment out Deezer calls in search function and also put a help comment in readme but I don't know what happens if I change the main branch and your updates are based on previous version. I appreciate it if you can do it (also comment the Deezer test) so the tests pass and I will merge the changes.

jmaximusix commented 3 weeks ago

Ok, I used black to reformat, and changed the functions back to lambdas.

Also commented out Deezer. Are we sure yet whether this broke permanently (due to an api change of theirs or sth) or if it's only temporarily down? Edit: Just saw you opened an issue, and based on the response seems like an api change you're right

If there's anything else you want to change before merging, let me know :)

moehmeni commented 3 weeks ago

Great. Thanks again!