search

moest-np / center-randomize

Script is to assign exam centers to students
MIT License
765 stars 363 forks source link

#84 Fixes of Schools are not plotted in map in streamlit app #90

Closed nirmala-sharma closed 1 month ago

nirmala-sharma commented 1 month ago

Fixes #84

While Filtering data , schools will also shown in map in different color than center when we apply both (school/center) filter .

sapradhan commented 1 month ago

Using school list like in your first commit is a better idea as school-center-distance has a much larger row count.

Also instead of re-reading from tsv can we use dataframe in tab3? and build a dict[scode , (lat,long)] from from it so that we dont have to traverse school list multiple times

github-advanced-security[bot] commented 1 month ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

nirmala-sharma commented 1 month ago

Using school list like in your first commit is a better idea as school-center-distance has a much larger row count.

Also instead of re-reading from tsv can we use dataframe in tab3? and build a dict[scode , (lat,long)] from from it so that we dont have to traverse school list multiple times

@sapradhan Completed these changes please review again.

sapradhan commented 1 month ago

thank you @nirmala-sharma One more request. is it possible to add legend somewhere. Blue marker = school, Red marker = center